Linus Torvalds

    0
    31
    RSS Source: https://lkml.org/
    Default Action: directlink
    Default Link Follow: nofollow
    Default Link Target: newtab
    Default Link Color is defined : #CDD8D8
    Feed Title: lkml.org

    Li Tuo writes: (Summary) Hello, Hello, Our static analysis tool finds a possible uninitialized-variable access in the memstick driver in Linux 5.14.0-rc3: in the memstick driver in Linux 5.14.0-rc3: At the beginning of the function rtsx_usb_ms_issue_cmd(), the variable int_reg is not initialized. If the following condition is true, it remains uninitialized. 469:ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ if (req->long_data) However, it is accessed in some statements such as: 491:ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ if (int_reg & MS_INT_CMDNK) I am not quite sure whether this possible uninitialized-variable access is real and how to fix it if it is real.

    kernel test robot writes: (Summary)

    Kent Gibson writes: On Thu, Jul 29, 2021 at 08:17:22PM -0700, Dipen Patel wrote: as well? I can't speak for Linus, but I'm fine with it as is as it allows the tool to be used to exercise the sanity check in the kernel. to be used to exercise the sanity check in the kernel. Cheers, Kent. Kent. Kent.

    Li Tuo writes: (Summary) Hello, Hello, Our static analysis tool finds a possible uninitialized-variable access in the firestream driver in Linux 5.14.0-rc3: in the firestream driver in Linux 5.14.0-rc3: In the function fs_open(), a memory block is allocated through kmalloc(), and its return value is assigned to the pointer vcc. , QE_CMD_CONFIG_TX | , QE_CMD_TX_EN | , QE_CMD_CONFIG_RX | , QE_CMD_CONFIG_RX | , QE_CMD_RX_EN |

    Li Tuo writes: (Summary) Hello, Hello, Our static analysis tool finds a possible uninitialized-variable access in the sis driver in Linux 5.14.0-rc3: in the sis driver in Linux 5.14.0-rc3: At the beginning of the function SiS_SetCRT2FIFO_300(), the variable modeidindex is not initialized. If the following conditions are false, it remains uninitialized. I am not quite sure whether this possible uninitialized-variable access is real and how to fix it if it is real.

    Jue Wang writes: (Summary) Been busy with some other work. Been busy with some other work. After cherry picking patch 1 & 2, I saw the following with 2 UC errors injected into the user space buffer passed into write(2), as expected: into the user space buffer passed into write(2), as expected: [ 287.994754] Kernel panic - not syncing: Machine checks to different user pages user pages The kernel tested with has its x86/mce and mm/memory-failure aligned with upstream till around 2020/11. upstream till around 2020/11. Is there any other patch that I have missed to the write syscall etc?

    Li Tuo writes: (Summary) Hello, Hello, Our static analysis tool finds a possible uninitialized-variable access in the jfs driver in Linux 5.14.0-rc3: in the jfs driver in Linux 5.14.0-rc3: At the beginning of the function xtSplitUp(), the variable rbn is not initialized. If sp->header.flag & xtSplitRoot(tid, ip, split, &rmp) : xtSplitPage(tid, ip, split, &rmp, &rbn); the varialbe rbn will remain uninitialized. However, it is accessed through: 814:ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ rcbn = rbn; 814:ÿ¿¿¿¿¿ÿ¿¿¿¿¿ÿ¿¿¿¿¿ rcbn = rbn; I am not quite sure whether this possible uninitialized-variable access is real and how to fix it if it is real. Any feedback would be appreciated, thanks! Any feedback would be appreciated, thanks! Reported-by: TOTE Robot

    Li Tuo writes: (Summary) Hello, Hello, Our static analysis tool finds a possible uninitialized-variable access in the nxp driver in Linux 5.14.0-rc3: in the nxp driver in Linux 5.14.0-rc3: At the beginning of the function lpc_eth_drv_probe(), the variable dma_handle is not initialized. If the following conditions are false, it remains uninitialized. I am not quite sure whether this possible uninitialized-variable access is real and how to fix it if it is real.

    Leo Yan writes: (Summary) On Wed, Jul 21, 2021 at 10:48:25AM +0100, Mike Leach wrote: + [CS_ETE_TRCDEVARCH] = "mgmt/trcdevarch" ETMv4 supports TRCDEVARCH, so I think it's good to use the naming "CS_ETMV4_TRCDEVARCH"? "CS_ETMV4_TRCDEVARCH"? + /* Get a handle on TRCIDR2 */ This is typo fixing; it's irrelevant to the topic in this patch, it's good to use a separate patch for the typo fixing. good to use a separate patch for the typo fixing. particular trace run. I checked ETMv4.3 and ETMv4.4 spec (ARM IHI0064E for ETMv4.3 and ARM IHI0064F for ETMv4.4), both clarify ETMv4 has the register TRCDEVARCH;

    Gayatri Kammela writes: (Summary) + +static const struct pmc_bit_map adl_power_gating_status_0_map[] = { + {"PMC_PGD0_PG_STS", BIT(0)}, + {"DMI_PGD0_PG_STS", BIT(1)}, + {"ESPISPI_PGD0_PG_STS", BIT(2)}, + {"XHCI_PGD0_PG_STS", BIT(3)}, + {"SPA_PGD0_PG_STS", BIT(4)}, + {"SPB_PGD0_PG_STS", BIT(5)}, + {"SPC_PGD0_PG_STS", BIT(6)}, + {"GBE_PGD0_PG_STS", BIT(7)}, + {"SATA_PGD0_PG_STS", BIT(8)}, + {"DSP_PGD0_PG_STS", BIT(9)}, + {"DSP_PGD1_PG_STS", BIT(10)}, + {"DSP_PGD2_PG_STS", BIT(11)}, + {"DSP_PGD3_PG_STS", BIT(12)}, + {"SPD_PGD0_PG_STS", BIT(13)}, + {"LPSS_PGD0_PG_STS", BIT(14)}, + {"SMB_PGD0_PG_STS", BIT(16)}, + {"ISH_PGD0_PG_STS", BIT(17)}, + {"NPK_PGD0_PG_STS", BIT(19)}, + {"PECI_PGD0_PG_STS", BIT(21)}, + {"XDCI_PGD0_PG_STS", BIT(25)}, + {"EXI_PGD0_PG_STS", BIT(26)}, + {"CSE_PGD0_PG_STS", BIT(27)}, + {"KVMCC_PGD0_PG_STS", BIT(28)}, + {"PMT_PGD0_PG_STS", BIT(29)}, + {"CLINK_PGD0_PG_STS", BIT(30)}, + {"PTIO_PGD0_PG_STS", BIT(31)}, + {} +};

    Wang Hai writes: (Summary) Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() and pci_release_regions() will be called in release automatically. called in release automatically. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/natsemi/natsemi.c b/drivers/net/ethernet/natsemi/natsemi.c index 51b4b25d15ad..84f7dbe9edff 100644 --- a/drivers/net/ethernet/natsemi/natsemi.c +++ b/drivers/net/ethernet/natsemi/natsemi.c @@ -819,7 +819,7 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent) printk(version); */ @@ -974,9 +974,6 @@ static int natsemi_probe1(struct pci_dev *pdev, const struct pci_device_id *ent) err_register_netdev: iounmap(ioaddr);

    Yu Zhao writes: (Summary) zram 10GB ~~~~~~~~~ best case 7.170s 3.559s -50.36% worst case 8.216s 8.94s +8.81% swap 10GB ~~~~~~~~~ best case 70.466s 3.544s -94.97% worst case 67.014s 65.521s -2.22% (noise) (CONFIG_THP_SWAP=n) zram (before) ============= best case ~~~~~~~~~ time 7.170s 21.78% clear_page_erms 16.47% zram_bvec_rw 2.90% clear_huge_page 2.74% _raw_spin_lock 2.65% page_vma_mapped_walk 2.41% flush_tlb_func 2.21% shrink_page_list 1.55% try_to_unmap_one 1.29% _raw_spin_lock_irqsave 1.25% page_counter_cancel 1.21% __mod_node_page_state 1.17% __mod_lruvec_page_state 1.10% add_to_swap_cache 1.08% xas_create 1.07% xas_store worst case ~~~~~~~~~~ time 8.216s 17.27% clear_page_erms 13.25% lzo1x_1_do_compress 4.35% zram_bvec_rw 3.41% memset_erms 3.23% _raw_spin_lock 2.88% page_vma_mapped_walk 2.75% clear_huge_page 2.28% flush_tlb_func 1.92% shrink_page_list 1.39% try_to_unmap_one 1.21% page_count

    Yu Zhao writes: (Summary) 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index afff3ac87067..d8b655856e79 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2342,17 +2342,14 @@ static void remap_page(struct page *page, unsigned int nr) } } -static void lru_add_page_tail(struct page *head, struct page *tail, - struct lruvec *lruvec, struct list_head *list) +static void lru_add_page_tail(struct page *head, struct page *tail, struct list_head *list) { VM_BUG_ON_PAGE(!PageHead(head), head);

    Yu Zhao writes: (Summary) 1 + 3 files changed, 30 insertions(+) diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h index ae0dd1948c2b..829eeac84094 100644 --- a/include/linux/vm_event_item.h +++ b/include/linux/vm_event_item.h @@ -99,6 +99,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD THP_SPLIT_PUD, #endif + THP_SPLIT_FREE, THP_ZERO_PAGE_ALLOC, THP_ZERO_PAGE_ALLOC_FAILED, THP_SWPOUT, diff --git a/mm/huge_memory.c b/mm/huge_memory.c index d8b655856e79..5120478bca41 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2432,6 +2432,8 @@ static void __split_huge_page(struct page *page, struct list_head *list, struct address_space *swap_cache = NULL;

    Yu Zhao writes: (Summary) + /* * Restore a potential migration pte to a working pte entry */ static bool remove_migration_pte(struct page *page, struct vm_area_struct *vma, - unsigned long addr, void *old) + unsigned long addr, void *arg) { + struct rmap_walk_arg *rmap_walk_arg = arg; */ -void remove_migration_ptes(struct page *old, struct page *new, bool locked) +void remove_migration_ptes(struct page *old, struct page *new, bool locked, bool unmap_clean) { + struct rmap_walk_arg rmap_walk_arg = { + .page = old, + .unmap_clean = unmap_clean, + };

    Kefeng Wang writes: (Summary) On 2021/6/10 20:35, Kefeng Wang wrote: ARM_LPAE enabled. Hiÿ¿¿¿¿¿ Russell, I make some changes according your advise, could you give me Hiÿ¿¿¿¿¿ Russell, I make some changes according your advise, could you give me some comments about this patchset, I want to make sure that whether they some comments about this patchset, I want to make sure that whether they can be sent toÿ¿¿¿¿¿ the ARM patch system,ÿ¿¿¿¿¿ many thanks. can be sent toÿ¿¿¿¿¿ the ARM patch system,ÿ¿¿¿¿¿ many thanks. - drop LPAE specific - drop LPAE specific

    Heiko Carstens writes: On Fri, Jul 30, 2021 at 10:07:41PM -0400, Steven Rostedt wrote: Reviewed-by: Steven Rostedt (VMware) Thanks a lot! Thanks a lot! Thanks a lot!

    LEAVE A REPLY

    Please enter your comment!
    Please enter your name here